Repository navigation
checker: explain smartcast narrowing in or {} / ? error on unwrapped option (fix #27130) - #27238
Merged
Merged
Conversation
…d option (fix #27130) When an option variable was narrowed to its unwrapped type by an earlier `if x == none { return }` check, using `or {}` or `?` on it produced a misleading "non-option variable" error. Mention the prior smartcast and suggest using the variable directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the error message for
or {}/?used on an option variable that has already been smartcast-narrowed to its unwrapped type by an earlierif x == none { return }(or!= none) check.Before:
cannot use `or {}` block on non-option variable— misleading, since the variable's declared type is?string.After:
cannot use `or {}` block on non-option variable `name` (it was already unwrapped to `string` by an earlier none check; use `name` directly).The new wording matches the "Alternative" suggested in the issue: it tells the user the variable was narrowed and what to do instead, instead of pretending the variable was never an option.
Fixes #27130.
Test plan
vlib/v/checker/tests/or_block_smartcast_unwrapped_err.vvcovers bothor {}and?on a smartcast-narrowed option variable./v -silent test vlib/v/compiler_errors_test.vpasses the new case./v selfrebuilds cleanly with the patched checker