Repository navigation
compiler: fix generic sumtype aliases and duplicate imports - #27523
Conversation
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: faeb9871ce
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9b63a6e55c
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c39c986211
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 619e4f30ee
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Fixes #27513
Fixes #27514
Fixes #27515
Testing
./vnew -silent test -run-only test_imports_with_same_resolved_path_are_parsed_once vlib/v/builder/builder_test.v./vnew -silent test -run-only test_duplicate_resolved_import_path_still_validates_module_name vlib/v/builder/builder_test.v./vnew -silent test vlib/v/tests/sumtypes/generic_sumtype_alias_regression_test.v./vnew -silent test vlib/v/tests/sumtypes/generic_sumtype_alias_match_regression_test.v./vnew -silent test vlib/v/tests/builtin_arrays/arraydecompose_nonvariadic_test.v./vnew -silent test vlib/v/tests/sumtypes/sumtype_with_fntype_test.v vlib/v/tests/sumtypes/sumtype_with_alias_fntype_test.v vlib/v/tests/sumtypes/sumtype_with_alias_fntype_fn_call_test.v vlib/v/tests/sumtypes/generic_sumtype_alias_regression_test.v vlib/v/tests/aliases/alias_is_match_runtime_tag_test.v./vnew -silent test vlib/v/checker/./vnew -silent vlib/v/compiler_errors_test.v./vnew -silent vlib/v/gen/c/coutput_test.vBroad suite note:
./vnew -silent test vlib/v/was started after the fix but stopped after reproducing existing local failures unrelated to this patch:vlib/v/builder/builder_test.vincludestcc compilation failed, falling back to ccwarnings in expected-clean stdout, andvlib/v/generics/new_generics_regression_test.vfails in the local-new-generic-solver test vlib/flag/run with C compilation errors.