Repository navigation
builtin/v.util: correct error underline for unicode wide chars - #9010
Merged
Merged
Conversation
zakuro9715
force-pushed
the
cjk-error-message
branch
from
February 28, 2021 08:16
49b3876 to
4d4e32a
Compare
Member
Author
|
Hmm... I have no idea why it's an error. No error occurs on my local environment. |
zakuro9715
force-pushed
the
cjk-error-message
branch
from
February 28, 2021 08:25
4d4e32a to
fe2ea92
Compare
spytheman
force-pushed
the
cjk-error-message
branch
from
February 28, 2021 21:18
fe2ea92 to
d541201
Compare
Contributor
|
(rebased over current master, after the optional PRs merge) |
Contributor
|
I think the problem is in the match handling. |
…d a c.warn about future simillar cases
Member
Author
|
Got it! I gained more knowledge about V internal |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently wrong underline is showed for source code that includes wide character like this.
encoding.utf8.east_asian.display_widthexists. But it has big table. So I added simplified detection toutf8_str_visible_length