Repository navigation
feat: only update cache-file for installed apps - #1419
Conversation
|
Applied the patch on my system, no problems so far. Good idea! |
|
I've been tossing around the idea of making a local script to do something similar in virtual machines on a spare computer. Maybe even having a separate VM for each supported release (bookworm, trixie, jammy, noble, etc) and testing every package in each, to be thorough. But the Github Workflow idea is probably better and less maintenance. My only worry would be about exceeding the allotted minutes if we install every package. (Not sure what tier they're on.) Although installing them all would be helpful in finding breakages early. Perhaps just updating the cache daily, and doing full installs only weekly or monthly would be sufficient. Or something like that. |
|
Agreed that it should do it on all supported releases, but unfortunately it doesn't look like GitHub Actions has them all, and |
Since wimpysworld#1419, get_github_releases, get_gitlab_releases, and get_website only refresh their cache files for 'install', 'fix-installed', or 'update' (the latter only when the package is installed). As a result, 'deb-get show <pkg>' on a non-installed package that uses one of those sources prints empty Published and Download lines — the per-package script reads the cache to derive URL and VERSION_PUBLISHED, but the cache was never fetched. Adding 'show' to the action allowlist keeps the 'no cache for apps we never install' intent in place (no change for list/prettylist/etc) while making sure 'show' returns a complete record for any supported package. Closes wimpysworld#1842
Since #1419, get_github_releases, get_gitlab_releases, and get_website only refresh their cache files for 'install', 'fix-installed', or 'update' (the latter only when the package is installed). As a result, 'deb-get show <pkg>' on a non-installed package that uses one of those sources prints empty Published and Download lines — the per-package script reads the cache to derive URL and VERSION_PUBLISHED, but the cache was never fetched. Adding 'show' to the action allowlist keeps the 'no cache for apps we never install' intent in place (no change for list/prettylist/etc) while making sure 'show' returns a complete record for any supported package. Closes #1842
Since wimpysworld#1419, get_github_releases, get_gitlab_releases, and get_website only refresh their cache files for 'install', 'fix-installed', or 'update' (the latter only when the package is installed). As a result, 'deb-get show <pkg>' on a non-installed package that uses one of those sources prints empty Published and Download lines — the per-package script reads the cache to derive URL and VERSION_PUBLISHED, but the cache was never fetched. Adding 'show' to the action allowlist keeps the 'no cache for apps we never install' intent in place (no change for list/prettylist/etc) while making sure 'show' returns a complete record for any supported package. Closes wimpysworld#1842
This PR will make it so that
deb-get updatewill only update the cache file for apps that are already installed.Unless I'm overlooking something, there doesn't seem to be any need to have the cache file for non-installed apps. When installing an app, it will still be downloaded if needed.
This should significantly reduce the amount that the Github API is being called for the average user, at least partially solving #757. As well as just speeding up the
deb-get updateprocess overall.This should also have the side-benefit of reducing the errors shown for apps that are not installed, as mentioned in #964.