Repository navigation
fix(novelwriter): use version tag over filename - #1718
Merged
Merged
Conversation
fixes wimpysworld#1717 Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- Possible tag corruption when stripping all "v" characters from URLs could break version parsing for tags like "v2.5.2-preview" in
01-main/packages/novelwriter - Score reflects a medium-severity behavior bug that could affect users relying on preview tags
- Pay close attention to
01-main/packages/novelwriter- ensure only a leading "v" is removed from the extracted tag.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="01-main/packages/novelwriter">
<violation number="1" location="01-main/packages/novelwriter:6">
P2: Stripping all "v" characters from the URL can corrupt tags that contain "v" beyond the prefix (e.g., "v2.5.2-preview" -> "2.5.2-preiew"). Extract the tag first and remove only a leading "v".</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1717