Repository navigation
fix(winegui): adapt to upstream packaging changes - #1736
Merged
Merged
Conversation
Member
Author
|
Expected the test to fail but not to get stuck for 25 mins - cancelled it |
philclifford
force-pushed
the
fix-winegui
branch
from
February 18, 2026 13:26
4314883 to
e94702b
Compare
Also until questing or sid packages are released install the forky or plucky ones as they currently install OK Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
closes 1699 Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
philclifford
force-pushed
the
fix-winegui
branch
from
February 23, 2026 00:58
e94702b to
cd3cb07
Compare
philclifford
marked this pull request as ready for review
February 23, 2026 00:59
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file
Confidence score: 3/5
- There is a concrete risk of breaking package processing because
localis used at top-level in01-main/packages/winegui, which will throw at runtime. - Severity is moderate (6/10) and likely user-facing, so this isn’t a no-risk merge.
- Pay close attention to
01-main/packages/winegui- top-levellocalusage may crash processing.
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="01-main/packages/winegui">
<violation number="1" location="01-main/packages/winegui:5">
P2: `local` is only valid inside a function. Using it at top-level will throw `local: can only be used in a function` and can break package processing. Define the variable without `local` here.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
teejee2008
pushed a commit
to teejee2008/deb-get
that referenced
this pull request
Feb 26, 2026
* fix(winegui): adapt to upstream packaging changes Also until questing or sid packages are released install the forky or plucky ones as they currently install OK * fix(winegui): upstream has kindly added publishing releases on GitHub for us closes wimpysworld#1699 Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
philclifford
added a commit
to philclifford/deb-get
that referenced
this pull request
Feb 27, 2026
* fix(winegui): adapt to upstream packaging changes Also until questing or sid packages are released install the forky or plucky ones as they currently install OK * fix(winegui): upstream has kindly added publishing releases on GitHub for us closes wimpysworld#1699 Signed-off-by: Phil Clifford <philip.clifford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also until questing or sid packages are released install the forky or plucky ones as they currently install OK
Closes #1699