[silentJET85]

closes #1797

[cubic-dev-ai]

No issues found across 1 file

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{Requires human review: This PR modifies core package validation logic and architecture matching in a shell script, which carries a risk of breaking package installations.}

[philclifford]

It seemed so innocuous but seems to contain or trigger a sneaky logic problem :-(

[philclifford]

compare

./deb-get prettylist 01-main |grep debian |head

between a610e25 and 586c866

I suspect it may break more than the listing but CI didn't test updating or (re)installing a few apps from each source ...

[silentJET85]

This puzzled me for a while.
It turns out that neither $HOST_ARCH nor "all" were matching. I'm surprised that installing apps somehow continued to work. After trying lots of things, I was starting to think that pipes and parenthesis don't work in combination with quoted strings. I ended up making a commit that avoided it by doing a separate [[ ]] test just for "all". That works, but is a bit ugly.

Then I finally realized that my original method was fine. The problem was simply some spaces around the pipe. Doh! 🤦