Repository navigation
Fixes 658 - add Trilium Notes - #736
Merged
Merged
Conversation
p4p4j0hn
marked this pull request as ready for review
February 3, 2023 12:25
Signed-off-by: John Schmidt <john@schmidthaus.rocks>
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
@philclifford Did I add that correctly? |
Member
|
@p4p4j0hn yes (although better in a line alone, and if you ever need to close more than one issue or PR with one merge they need to be separately mentioned one per line) You can see over there |
Contributor
Author
|
Thanks for the tips/mentorship @philclifford 😄 |
philclifford
approved these changes
Mar 1, 2023
philclifford
left a comment
philclifford
left a comment
Member
There was a problem hiding this comment.
LGTM
(in fact worked most excellently)
Member
|
You're most welcome. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #658
Add support for installing Trilium Notes.