Skip to content

feat: Initial support for Termius (fixes #864) - #902

Merged
philclifford merged 2 commits into
wimpysworld:mainfrom
rasa:rasa/termius
Nov 18, 2023
Merged

philclifford merged 2 commits into
wimpysworld:mainfrom
rasa:rasa/termius

Conversation

@rasa

@rasa rasa commented Oct 6, 2023

Copy link
Copy Markdown
Contributor

First submission so feedback appreciated.

@rasa

rasa commented Oct 6, 2023 •

Copy link
Copy Markdown
Contributor Author

The CI failed, so I submitted this bug report to Termius' Customer Support page:


Hey, I am a licensed Termius user, and submitted a GitHub PR to the deb-get project to add Termius at https://github.com//pull/902

Unfortunately, Termius failed to install, with the error:

/var/lib/dpkg/info/termius-app.postinst: line 10: update-desktop-database: command not found

The update-desktop-database command is provided by the desktop-file-utils package, which doesn't appear to be installed in the ubuntu-22.04 GitHub VM (actually Ubuntu 22.04.3 LTS per https://github.com/wimpysworld/deb-get/actions/runs/6434539335/job/17473961566#step:1:2 ) instance that the CI uses.

Is the issue fixable on my end, or does the .deb file need to be repackaged?

Thanks,
Ross

@philclifford philclifford left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to match the installed app exactly or remove will not work. s/termius/termius-app/ in manifest and rename the package definition file to termius-app

@philclifford

philclifford commented Nov 2, 2023 •

Copy link
Copy Markdown
Member

Is the issue fixable on my end, or does the .deb file need to be repackaged?

They really need to fix their dependency. The CI doesn't install a desktop into the test environment, hence the lack of desktop-file-utils (it is included in any of the desktop apt installation "tasks").

We need to think about improving the CI testing on several fronts. I'll add this to the issues list.

If you rename the package file to match the application (termius-app) I see no need to wait for upstream to improve their packaging before merging this, but that would be the correct thing to do.

Thanks for your contribution.

@rasa

rasa commented Nov 2, 2023

Copy link
Copy Markdown
Contributor Author

You need to match the installed app exactly or remove will not work. s/termius/termius-app/ in manifest and rename the package definition file to termius-app

@philclifford Done. Thanks for your help. Still getting up to speed here.

@philclifford
philclifford merged commit d78c3ba into wimpysworld:main Nov 18, 2023
@rasa
rasa deleted the rasa/termius branch November 18, 2023 16:32
hsbasu pushed a commit to mamolinux/deb-get that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants