Skip to content
This repository was archived by the owner on Aug 2, 2022. It is now read-only.

Increase get info priority to medium high - develop - #8896

Merged
allenhan2 merged 2 commits into
developfrom
get_info_higher_priority-develop
Mar 30, 2020
Merged

allenhan2 merged 2 commits into
developfrom
get_info_higher_priority-develop

Conversation

@allenhan2

Copy link
Copy Markdown
Contributor

Change Description

related issue #8655
Raise the priority of get_info call for better user response time.

Call tests (30 minutes, 16 threads):
Thread 0, run 26114 times, total(s): 1799.16, avg(ms): 68.90, min(ms): 19.76, max(ms): 4439.54
Thread 1, run 26138 times, total(s): 1799.36, avg(ms): 68.84, min(ms): 20.49, max(ms): 4435.66
Thread 2, run 26135 times, total(s): 1799.37, avg(ms): 68.85, min(ms): 20.39, max(ms): 4433.70
Thread 3, run 26111 times, total(s): 1799.29, avg(ms): 68.91, min(ms): 17.80, max(ms): 4430.04
Thread 4, run 26073 times, total(s): 1799.29, avg(ms): 69.01, min(ms): 20.09, max(ms): 4435.23
Thread 5, run 26120 times, total(s): 1799.33, avg(ms): 68.89, min(ms): 20.84, max(ms): 4416.55
Thread 6, run 26157 times, total(s): 1799.32, avg(ms): 68.79, min(ms): 19.02, max(ms): 4416.58
Thread 7, run 26072 times, total(s): 1799.30, avg(ms): 69.01, min(ms): 20.39, max(ms): 4449.16
Thread 8, run 26132 times, total(s): 1799.29, avg(ms): 68.85, min(ms): 19.86, max(ms): 4430.26
Thread 9, run 26173 times, total(s): 1799.28, avg(ms): 68.75, min(ms): 18.74, max(ms): 4426.70
Thread 10, run 26143 times, total(s): 1799.29, avg(ms): 68.82, min(ms): 20.16, max(ms): 4422.82
Thread 11, run 26140 times, total(s): 1799.32, avg(ms): 68.83, min(ms): 19.18, max(ms): 4429.03
Thread 12, run 26136 times, total(s): 1799.33, avg(ms): 68.84, min(ms): 20.47, max(ms): 4443.78
Thread 13, run 26139 times, total(s): 1799.33, avg(ms): 68.84, min(ms): 20.56, max(ms): 4416.20
Thread 14, run 26116 times, total(s): 1799.34, avg(ms): 68.90, min(ms): 20.71, max(ms): 4439.18
Thread 15, run 26112 times, total(s): 1799.38, avg(ms): 68.91, min(ms): 19.50, max(ms): 4454.02
Run 418011 times, total(s): 28788.98, avg(ms): 68.87, min(ms): 17.80, max(ms): 4454.02

It is an improvement, not an ultimate solution yet.

BTW, during get_info calls, NOT seen a significant impact on nodeos syncing latency time,

Consensus Changes

  • Consensus Changes

API Changes

  • API Changes

Documentation Additions

  • Documentation Additions

@allenhan2
allenhan2 requested a review from heifner March 30, 2020 17:09
@heifner heifner changed the title Get info higher priority develop Get info higher priority - develop Mar 30, 2020
@allenhan2
allenhan2 marked this pull request as ready for review March 30, 2020 17:11
@heifner

heifner commented Mar 30, 2020

Copy link
Copy Markdown
Contributor

See #8894

@heifner heifner changed the title Get info higher priority - develop Increase get info priority to medium high - develop Mar 30, 2020
@allenhan2
allenhan2 merged commit 0e9f3c9 into develop Mar 30, 2020
@allenhan2
allenhan2 deleted the get_info_higher_priority-develop branch March 30, 2020 20:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants