Repository navigation
Fix crash when the template Metadata is not an object - #4807
Merged
kddejong merged 1 commit intoOct 21, 2026
Merged
Conversation
kddejong
approved these changes
Oct 21, 2026
kddejong
force-pushed
the
fix-non-object-template-metadata
branch
from
October 21, 2026 17:17
ab3d272 to
389b3ee
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4807 +/- ##
=======================================
Coverage 94.72% 94.72%
=======================================
Files 439 439
Lines 15908 15910 +2
Branches 3079 3079
=======================================
+ Hits 15069 15071 +2
Misses 458 458
Partials 381 381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4768
Issue #, if available: #4768
Description of changes:
TemplateArgs.set_template_argsnow treats a non-object top-levelMetadata(string, null, list) or a non-objectMetadata.cfn-lintas having no cfn-lint config, instead of raisingAttributeError.'hello' is not of type 'object'.Related: #4784 fixes the same crash shape for resource-level
Metadata(#4769).By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.