Repository navigation
Redesign onboarding library type selection - #355
Conversation
|
I see you split the original SVGs into two such that they could be stacked vertically :). That was what I was talking about: the GtkImage widgets just had to have 1:1 sizing. I mistakenly wrote left-right padding earlier; it was top-bottom stemming from the horizontal figure being inside a 1:1 space. The raised button style on the right looks better IMHO as it's more obvious to the user that they're selectable, but I'm not sure I vibe with the custom highlighting. Can we restore the radio buttons with them placed below the button labels and centrally justified? They can then indicate which option is being selected without needing custom CSS to highlight the whole button. Nothing against custom styling for the more exotic bits, but for buttons I'd prefer we stick to stock ones just in case people do custom theming.
I only have issues with the title text which is now a bit too big relative to the space it's in (previously in my design the excess spacing I mentioned helped make it look less cramped). Maybe we can drop to
Okay so here's my attempt at wording it, feel free to adjust: Why does this matter? <-- I think the accordion title should say this instead? I don't wanna make it sound exclusive to Euphonica as it certainly helps other players too. Knowing the folder layout beforehand allows Euphonica to optimise cover art loading. If each folder is guaranteed to contain tracks from only one release, then Euphonica can download cover art exactly once per folder and apply it to all tracks within. This is either a dedicated However, if a folder contains tracks from multiple releases, one release's cover art would then be mistakenly applied to tracks from other releases. Should your library fall into this case, please select (note: I kept the escaped Pango styling tags for copying convenience but had to wrap them in backticks to prevent GitHub from unhelpfully processing them; when copying into the .ui file please remove the backticks). |
|
Looks superb, thanks a tonne. I'll merge now as the other PR about MPD orchestration needs to use this as basis for its connection wizard. Last nitpick: The contents should live in a ScrolledWindow so smaller screens like mobile devices can still display this (vertical scrolling only). The "Start" button at the end will stay outside though & be always visible. I'll do it myself after merging to avoid troubling you further though. |



Closes #351
I left the help accordion's text as placeholder for now, let me know what I should put there.
Also lmk if the
Start using Euphonicabutton should be at the bottom like it is now or simply come after the accordion.Not sure if the padding is fine