Skip to content

allow absent conflict condition for non-conflicted listeners - #4642

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
zhaohuabing:allow-absent-conflict-condition-for-none-conflicted-listeners
Mar 10, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
zhaohuabing:allow-absent-conflict-condition-for-none-conflicted-listeners

Conversation

@zhaohuabing

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind test
/area conformance-test

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #4618

Does this PR introduce a user-facing change?:

The `conflicted=false` condition is not required anymore in the listener status for non-conflicted listeners.

Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/test area/conformance-test Issues or PRs related to Conformance tests. labels Mar 6, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @zhaohuabing. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 6, 2026
@zhaohuabing

Copy link
Copy Markdown
Contributor Author

Can we backport this to v1.5.1?

@robscott

robscott commented Mar 6, 2026

Copy link
Copy Markdown
Member

/cc @rikatz @davidjumani

@rikatz

rikatz commented Mar 9, 2026

Copy link
Copy Markdown
Member

/approve

@davidjumani @zhaohuabing we need some update on the GEP as well

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2026
@zhaohuabing

Copy link
Copy Markdown
Contributor Author

/approve

@davidjumani @zhaohuabing we need some update on the GEP as well

I can update the GEP in a follow-up PR if that works for you.

@zirain

zirain commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidjumani, rikatz, zhaohuabing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidjumani

Copy link
Copy Markdown
Contributor

/retest

@davidjumani

Copy link
Copy Markdown
Contributor

Updated the GEP && doc in #4659

@zirain

zirain commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2026
@zirain

zirain commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

/cherry-pick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@zirain: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
k8s-ci-robot merged commit 4f72a2e into kubernetes-sigs:main Mar 10, 2026
20 checks passed
@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@zirain: new pull request created: #4664

Details

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@davidjumani

Copy link
Copy Markdown
Contributor

/cherrypick release-1.5

@k8s-infra-cherrypick-robot

Copy link
Copy Markdown
Contributor

@davidjumani: new pull request could not be created: failed to create pull request against kubernetes-sigs/gateway-api#release-1.5 from head k8s-infra-cherrypick-robot:cherry-pick-4642-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.5 and k8s-infra-cherrypick-robot:cherry-pick-4642-to-release-1.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"}

Details

In response to this:

/cherrypick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance-test Issues or PRs related to Conformance tests. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/test lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question/clarification: GEP-1713 Conflicted behavior for non-conflicting listeners

7 participants