Repository navigation
allow absent conflict condition for non-conflicted listeners - #4642
Conversation
Signed-off-by: Huabing (Robin) Zhao <zhaohuabing@gmail.com>
|
Hi @zhaohuabing. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Can we backport this to v1.5.1? |
|
/cc @rikatz @davidjumani |
|
/approve @davidjumani @zhaohuabing we need some update on the GEP as well |
I can update the GEP in a follow-up PR if that works for you. |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidjumani, rikatz, zhaohuabing The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
Updated the GEP && doc in #4659 |
|
/lgtm |
|
/cherry-pick release-1.5 |
|
@zirain: once the present PR merges, I will cherry-pick it on top of DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@zirain: new pull request created: #4664 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick release-1.5 |
|
@davidjumani: new pull request could not be created: failed to create pull request against kubernetes-sigs/gateway-api#release-1.5 from head k8s-infra-cherrypick-robot:cherry-pick-4642-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"No commits between kubernetes-sigs:release-1.5 and k8s-infra-cherrypick-robot:cherry-pick-4642-to-release-1.5"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind test
/area conformance-test
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #4618
Does this PR introduce a user-facing change?: