Skip to content

Bump K8s dependencies to 1.36 - #4819

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
erikgb:k8s-1-36-deps
May 4, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
erikgb:k8s-1-36-deps

Conversation

@erikgb

@erikgb erikgb commented May 1, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This PR bumps the K8s dependencies, including controller-runtime, to the 1.36 versions.

It was required to bump golangci-lint to a newer version to support Go 1.26. If you want, I can extract this change into a separate PR. Update: I created #4820 to bump golangci-lint.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 1, 2026
@k8s-ci-robot
k8s-ci-robot requested review from candita and youngnick May 1, 2026 17:00
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 1, 2026
@erikgb
erikgb force-pushed the k8s-1-36-deps branch 4 times, most recently from 079b28e to 83abc33 Compare May 1, 2026 17:55
@erikgb
erikgb force-pushed the k8s-1-36-deps branch 2 times, most recently from 0c30f44 to f8e9792 Compare May 2, 2026 14:46
@erikgb erikgb changed the title WIP: Bump K8s dependencies to 1.36 Bump K8s dependencies to 1.36 May 2, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 2, 2026
Signed-off-by: Erik Godding Boye <egboye@gmail.com>

@snorwin snorwin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erikgb thanks!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2026
@rikatz

rikatz commented May 4, 2026

Copy link
Copy Markdown
Member

/approve

thanks!

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, rikatz, snorwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 2dac74e into kubernetes-sigs:main May 4, 2026
20 checks passed
wallrj-cyberark added a commit to cert-manager/cert-manager that referenced this pull request Jun 30, 2026
…pi v1.6.0

gateway-api v1.6.0 bumped to k8s 1.36 deps (kubernetes-sigs/gateway-api#4819),
which picked up the removal of the Deprecated godoc annotation from
gwfake.NewSimpleClientset (kubernetes/kubernetes#136455). With no deprecation
notice, staticcheck SA1019 no longer fires, so the //nolint:staticcheck directive
became dead code that nolintlint now rejects.

Also expand the FIXME comment to link to the root-cause issue
(kubernetes/kubernetes#126850) and the un-deprecation PR, so future readers
understand why NewSimpleClientset is still used deliberately.

Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants