Repository navigation
Bump K8s dependencies to 1.36 - #4819
Merged
Merged
Conversation
erikgb
force-pushed
the
k8s-1-36-deps
branch
4 times, most recently
from
May 1, 2026 17:55
079b28e to
83abc33
Compare
erikgb
force-pushed
the
k8s-1-36-deps
branch
2 times, most recently
from
May 2, 2026 14:46
0c30f44 to
f8e9792
Compare
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
snorwin
approved these changes
May 2, 2026
Member
|
/approve thanks! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb, rikatz, snorwin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wallrj-cyberark
added a commit
to cert-manager/cert-manager
that referenced
this pull request
Jun 30, 2026
…pi v1.6.0 gateway-api v1.6.0 bumped to k8s 1.36 deps (kubernetes-sigs/gateway-api#4819), which picked up the removal of the Deprecated godoc annotation from gwfake.NewSimpleClientset (kubernetes/kubernetes#136455). With no deprecation notice, staticcheck SA1019 no longer fires, so the //nolint:staticcheck directive became dead code that nolintlint now rejects. Also expand the FIXME comment to link to the root-cause issue (kubernetes/kubernetes#126850) and the un-deprecation PR, so future readers understand why NewSimpleClientset is still used deliberately. Signed-off-by: Richard Wall <richard.wall@cyberark.com>
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR bumps the K8s dependencies, including controller-runtime, to the 1.36 versions.
It was required to bump golangci-lint to a newer version to support Go 1.26. If you want, I can extract this change into a separate PR.Update: I created #4820 to bump golangci-lint.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: