Skip to content

Bump golangci-lint (and KAL) to support Go 1.26 - #4820

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
erikgb:bump-golangci-lint
May 2, 2026
Merged

k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
erikgb:bump-golangci-lint

Conversation

@erikgb

@erikgb erikgb commented May 1, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Prerequisite to #4819, which requires Go 1.26 as the minimum version.

Some new linter errors were fixed, others were suppressed - mainly in tests and because fixing them requires considerable work.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels May 1, 2026
@k8s-ci-robot
k8s-ci-robot requested review from candita and rikatz May 1, 2026 18:04
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 1, 2026
@erikgb
erikgb force-pushed the bump-golangci-lint branch from 336b58d to 7cc4e49 Compare May 1, 2026 18:37
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb
erikgb force-pushed the bump-golangci-lint branch from 7cc4e49 to b3ae9e9 Compare May 1, 2026 18:40
@erikgb erikgb changed the title WIP: Bump golangci-lint (and KAL) to support Go 1.26 Bump golangci-lint (and KAL) to support Go 1.26 May 1, 2026
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 1, 2026
@rikatz

rikatz commented May 2, 2026

Copy link
Copy Markdown
Member

/lgtm
/approve
thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 0d81b0f into kubernetes-sigs:main May 2, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants