Skip to content

fix(sound): source volume changes applied to sink - #2098

Merged
jacobgkau merged 1 commit into
masterfrom
sink
Jul 21, 2026
Merged

jacobgkau merged 1 commit into
masterfrom
sink

Conversation

@mmstick

@mmstick mmstick commented Jul 21, 2026

Copy link
Copy Markdown
Member

Closes #2097


  • I have disclosed use of any AI generated code in my commit messages.
    • If you are using an LLM, and do not fully understand the changes it is making to the code base, do not create a PR.
    • In our experience, AI generated code often results in overly complex code that lacks enough context for a proper fix or feature inclusion. This results in considerably longer code reviews. Due to this, AI authored or partially authored PRs may be closed without comment.
  • I understand these changes in full and will be able to respond to review comments.
  • My change is accurately described in the commit message.
  • My contribution is tested and working as described.
  • I have read the Developer Certificate of Origin and certify my contribution under its conditions.

@mmstick
mmstick requested review from a team July 21, 2026 16:11
@jacobgkau jacobgkau self-assigned this Jul 21, 2026

@jacobgkau jacobgkau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this was caused by #2063. Not sure what testing was performed on the sound page for that PR since the notes don't specify any.

The fix works. No other pages are being modified, so the full checklist for the rest of the pages isn't needed.

@jacobgkau
jacobgkau merged commit c262496 into master Jul 21, 2026
10 of 11 checks passed
@jacobgkau
jacobgkau deleted the sink branch July 21, 2026 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Changing Input Volume in Sound Settings Also Changes Output Volume

3 participants