[Doc] Fix autosummary to show docstring of class members - #32520
Merged
Conversation
Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
jjyao
marked this pull request as ready for review
February 14, 2023 08:07
jjyao
requested review from
a team,
DmitriGekhtman,
Yard1,
amogkam,
architkulkarni,
c21,
clarkzinzow,
edoakes,
ericl,
jianoaix,
jiaodong,
krfricke,
matthewdeng,
maxpumperla,
pcmoritz,
richardliaw,
scv119,
shrekris-anyscale,
sihanwang41,
simon-mo,
wuisawesome and
xwjiang2010
as code owners
February 14, 2023 08:07
maxpumperla
approved these changes
Feb 14, 2023
maxpumperla
left a comment
maxpumperla
left a comment
Contributor
There was a problem hiding this comment.
This is great, thanks for this pragmatic fix!
7 tasks
jjyao
added a commit
that referenced
this pull request
Feb 14, 2023
By default, autosummary only shows one line for each class member instead of the entire docstring. Ideally the fix should be autosummarying class members as well but that generates too many doc pages and causes doc build timeout. For now, default to show docstring of class members in the class pages and an explicit opt-in to autosummary class members. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com>
7 tasks
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
By default, autosummary only shows one line for each class member instead of the entire docstring. Ideally the fix should be autosummarying class members as well but that generates too many doc pages and causes doc build timeout. For now, default to show docstring of class members in the class pages and an explicit opt-in to autosummary class members. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
By default, autosummary only shows one line for each class member instead of the entire docstring. Ideally the fix should be autosummarying class members as well but that generates too many doc pages and causes doc build timeout. For now, default to show docstring of class members in the class pages and an explicit opt-in to autosummary class members. Signed-off-by: Jiajun Yao <jeromeyjj@gmail.com> Signed-off-by: elliottower <elliot@elliottower.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jiajun Yao jeromeyjj@gmail.com
Why are these changes needed?
By default, autosummary only shows one line for each class member instead of the entire docstring. Ideally the fix should be autosummarying class members as well but that generates too many doc pages and causes doc build timeout. For now, default to show docstring of class members in the class pages and an explicit opt-in to autosummary class members.
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.