[AIR][Doc] Add back important Ray Train integration methods (for Torch/TF) - #32551
Merged
Conversation
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
justinvyu
requested review from
a team,
Yard1,
amogkam,
gjoliver,
krfricke,
matthewdeng,
maxpumperla,
richardliaw and
xwjiang2010
as code owners
February 14, 2023 22:49
7 tasks
matthewdeng
reviewed
Feb 14, 2023
matthewdeng
left a comment
matthewdeng
left a comment
Contributor
There was a problem hiding this comment.
In general looks good to me, will take another look when the docs render.
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Contributor
Author
|
@matthewdeng Changes made. Rendered version from before for review: https://ray--32551.org.readthedocs.build/en/32551/ |
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…fix_air_api_refs
matthewdeng
approved these changes
Feb 15, 2023
Contributor
|
Seems the latest doc build timed out (>3000s). Can we reduce the usage of template class_with_autosummary? |
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
…fix_air_api_refs
Signed-off-by: Justin Yu <justinvyu@berkeley.edu>
justinvyu
requested review from
edoakes,
jiaodong and
simon-mo
as code owners
February 15, 2023 09:03
justinvyu
requested review from
DmitriGekhtman,
architkulkarni,
pcmoritz,
shrekris-anyscale,
sihanwang41 and
wuisawesome
as code owners
February 15, 2023 09:03
justinvyu
commented
Feb 15, 2023
| .. rubric:: {{ _('Methods') }} | ||
|
|
||
| .. autosummary:: | ||
| :toctree: |
Contributor
Author
There was a problem hiding this comment.
@jjyao This is needed to prevent every single member from getting its own file. This is often not what you want when you "opt in" to class_with_autosummary.
maxpumperla
approved these changes
Feb 15, 2023
jjyao
pushed a commit
that referenced
this pull request
Feb 15, 2023
edoakes
pushed a commit
to edoakes/ray
that referenced
this pull request
Mar 22, 2023
…h/TF) (ray-project#32551) Signed-off-by: Edward Oakes <ed.nmi.oakes@gmail.com>
peytondmurray
pushed a commit
to peytondmurray/ray
that referenced
this pull request
Mar 22, 2023
elliottower
pushed a commit
to elliottower/ray
that referenced
this pull request
Apr 22, 2023
…h/TF) (ray-project#32551) Signed-off-by: elliottower <elliot@elliottower.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The API restructure from #32360 accidentally removed important Ray Train utilities such as
ray.train.torch.prepare_modelandray.train.tensorflow.prepare_dataset_shard. This PR adds these back as part of the Train API ref.This PR also fixes doc failures/link checks that resulted from moved files/duplicate API refs (from #32520).
Related issue number
Checks
git commit -s) in this PR.scripts/format.shto lint the changes in this PR.