Repository navigation
Match date_formats month and weekday names in the given languages - #1486
Merged
AdrianAtZyte merged 1 commit intoSep 30, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1486 +/- ##
==========================================
+ Coverage 97.21% 97.26% +0.04%
==========================================
Files 236 236
Lines 3093 3139 +46
==========================================
+ Hits 3007 3053 +46
Misses 86 86 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
AdrianAtZyte
marked this pull request as ready for review
September 29, 2026 21:31
AdrianAtZyte
pushed a commit
that referenced
this pull request
Oct 27, 2026
#1486 tries every combination of the English names that each month or weekday name of the string can stand for. A name with two meanings, such as Spanish "mar" (martes or marzo), doubles the number of combinations, so a string with many such names made parse() with date_formats try an ever larger number of strptime calls before giving up. Try only the first _MAX_TRANSLATIONS combinations, the same limit that #1491 uses for the other readings of words with several meanings. Tested: a new test checks that 12 "mar" yield exactly _MAX_TRANSLATIONS distinct readings (it got 4096 before the change); the #1486 tests still pass; full suite, ruff and mypy pass. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #433