Repository navigation
Limit the name readings tried for date_formats - #1552
Merged
AdrianAtZyte merged 1 commit intoOct 27, 2026
Merged
Conversation
scrapinghub#1486 tries every combination of the English names that each month or weekday name of the string can stand for. A name with two meanings, such as Spanish "mar" (martes or marzo), doubles the number of combinations, so a string with many such names made parse() with date_formats try an ever larger number of strptime calls before giving up. Try only the first _MAX_TRANSLATIONS combinations, the same limit that scrapinghub#1491 uses for the other readings of words with several meanings. Tested: a new test checks that 12 "mar" yield exactly _MAX_TRANSLATIONS distinct readings (it got 4096 before the change); the scrapinghub#1486 tests still pass; full suite, ruff and mypy pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1552 +/- ##
=======================================
Coverage 99.18% 99.18%
=======================================
Files 239 239
Lines 4030 4030
=======================================
Hits 3997 3997
Misses 33 33 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1486.
#1486 tries every combination of the English names that the month and weekday names of the string can stand for. Each name with two meanings, such as Spanish "mar" (martes or marzo), doubles the number of combinations, so a string with many of them makes
parse()withdate_formatstry an ever larger number ofstrptimecalls before it returnsNone.This keeps only the first
_MAX_TRANSLATIONS(16) combinations, the limit #1491 already uses for the other readings of words with several meanings. The first combination is the one #1486 tried first, so strings with a few such names, like the ones in the #1486 tests, parse as before.🤖 Generated with Claude Code