Skip to content

Checker: change more than 1000 possibilities in match range to notice - #19862

Merged
spytheman merged 2 commits into
vlang:masterfrom
lemoncmd:match_range_1000
Nov 14, 2023
Merged

spytheman merged 2 commits into
vlang:masterfrom
lemoncmd:match_range_1000

Conversation

@lemoncmd

@lemoncmd lemoncmd commented Nov 13, 2023 •

Copy link
Copy Markdown
Contributor

because it is not user's fault but compiler's. it shouldn't be an error with -prod

πŸ€– Generated by Copilot at e6eca41

Changed the warning level and wording of a match range message in vlib/v/checker/match.v to better inform the user about the compile time impact of large ranges.

πŸ€– Generated by Copilot at e6eca41

  • Change the warning message for a large match range to a note message, and clarify the impact on compile time (link)

@Delta456

Copy link
Copy Markdown
Member

I wonder why is this even there.

@lemoncmd

Copy link
Copy Markdown
Contributor Author

why does tests-sanitize-address-gcc take so long?

@lemoncmd

Copy link
Copy Markdown
Contributor Author

@Delta456 I found the reason in #9010: checker uses an inefficient algorithm for exhaustive check.

@Delta456

Copy link
Copy Markdown
Member

@Delta456 I found the reason in #9010: checker uses an inefficient algorithm for exhaustive check.

I feel a separate issue should be made for this and be fixed.

@spytheman
spytheman merged commit dd81cb9 into vlang:master Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants