Repository navigation
fix(docker-desktop): Fix regex for extracting published version - #1528
Merged
Merged
Conversation
MH0386
marked this pull request as ready for review
September 26, 2025 19:06
philclifford
approved these changes
Sep 30, 2025
philclifford
pushed a commit
that referenced
this pull request
Aug 20, 2026
Both URL and VERSION_PUBLISHED extraction currently fail, so the package errors out with "Missing required information" and is skipped. VERSION_PUBLISHED used awk's three-argument match(), a gawk extension that errors under mawk, the default awk on Debian and Ubuntu. This regressed in 753bfac (#1546), which reverted the grep -oP fix from 204423e (#1528). The scraped URL was also malformed: a greedy match across the release-notes markup dropped a path separator, producing .../amd64236836/... which 403s. Switch to the appcast Docker Desktop's own updater consumes, which provides the version, build number and artifact URL as data rather than markup. Select on highest BuildNumber, since entries are ordered oldest-first and carry a staged-rollout Visibility percentage, so neither document order nor Visibility==100 identifies the newest build. VERSION_PUBLISHED is now AppVersion-BuildNumber, matching the .deb's own Version field. The previous bare version compared as older than an installed build under dpkg --compare-versions, so rebuilds of the same version were silently missed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01B6S1VtnD2yAkAXYsrfR1Kp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#1527
This pull request updates the logic for extracting the published version number of Docker Desktop from the cached release notes file. The new approach uses a more robust
grepcommand with Perl-compatible regular expressions to accurately capture the version string.Release version extraction improvement:
VERSION_PUBLISHEDassignment in01-main/packages/docker-desktopto usegrep -oPfor more precise extraction of the Docker Desktop version number from the release notes cache file.