[philclifford]

fixes #1507
replaces #1492
closes #1509

A lot of slightly-different implementations have arisen because of many valuable contributions re-using prior art at the same time as many other valuable contributions have
improved style, functionality, performance.
This is an attempt to standardise the majority of "similar" definitions. Besides conforming white-space styling to the model set out in the EXTREPO.md the main changes have been

• replace variations on echo "${URL}"| ... | tr -d v with <<< "${URL/v/}"
• replace some sed invocations with similar variable substitutions
• remove quotes around $( ) invocations .

The CI test is failing to install all the changed packages. This has identified a couple of issues but some that fall over in CI install OK locally. Looks like either a long wade through breaking changes to get to a squashable PR, a hard look at the CI to try and fix some issues there and improve behaviour or parking and splitting this PR into a lot of individual changes for each definition (excluding the deprecations and ones where pending PRs (most of which have been aligned with this work) might apply.

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Requires human review: Large-scale refactor affecting 222+ files with known CI failures and potential breaking changes to package installation logic.}

[cubic-dev-ai]

2 issues found across 1 file (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="01-main/packages/input-leap">

<violation number="1" location="01-main/packages/input-leap:2">
P2: Keep using the GitHub `latest` endpoint here; removing it can make this definition resolve a prerelease asset instead of the latest stable release.</violation>

<violation number="2" location="01-main/packages/input-leap:15">
P2: This fallback URL matcher is broken: `${ARCH}` is undefined in this file, and `browser_download_url.` should be `browser_download_url.*`, so the grep will not find any asset.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[cubic-dev-ai]

0 issues found across 1 file (changes from recent commits).

_{Requires human review: This is a massive refactor touching over 200 files. It modifies core string parsing logic for URLs and versions across many packages and has failing CI tests.}

[cubic-dev-ai]

0 issues found across 9 files (changes from recent commits).

_{Requires human review: Large scale changes to shell script logic (string parsing/substitution) across 200+ files with failing CI tests; too high-risk for auto-approval.}

[snoack]

@philclifford Since you removed clamav with this change, I keep getting following message on deb-get update:

  [!] ERROR! Missing required information of package clamav:
DEFVER=
PRETTY_NAME=
SUMMARY=
WEBSITE=

Is that some kind of bug triggered by a package that previously existed being removed?

[philclifford]

Yes @snoack - clamav should not have gone missing!