Skip to content

Feat: allow "all" archs - fixed - #1817

Merged
philclifford merged 3 commits into
wimpysworld:mainfrom
silentJET85:all-archs
Mar 22, 2026
Merged

philclifford merged 3 commits into
wimpysworld:mainfrom
silentJET85:all-archs

Conversation

@silentJET85

@silentJET85 silentJET85 commented Mar 22, 2026 •

Copy link
Copy Markdown
Contributor

fixed version of #1802
re-implements #1797

This puzzled me for a while.
It turns out that neither $HOST_ARCH nor "all" were matching. I'm surprised that installing apps somehow continued to work. After trying lots of things, I was starting to think that pipes and parenthesis don't work in combination with quoted strings. I ended up making a commit that avoided it by doing a separate [[ ]] test just for "all". That works, but is a bit ugly.

Then I finally realized that my original method was fine. The problem was simply some spaces around the pipe. Doh! 🤦

Originally posted by @silentJET85 in #1802 (comment)

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: This change modifies core logic for package validation, listing, and installation within deb-get. Logic changes in core paths require human review.

@philclifford
philclifford merged commit 45c47bb into wimpysworld:main Mar 22, 2026
2 checks passed
@silentJET85
silentJET85 deleted the all-archs branch March 31, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants